Fixed firebase regression in AndroidGradleBuilder.

codenameone · Mar 10, 2023 · 60727b2 · 60727b2
1 parent 9154995
commit 60727b2
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/...n/codenameone-maven-plugin/src/main/java/com/codename1/builders/AndroidGradleBuilder.java b/...n/codenameone-maven-plugin/src/main/java/com/codename1/builders/AndroidGradleBuilder.java
@@ -1168,11 +1168,22 @@ public void usesClassMethod(String cls, String method) {
                 debug("Adding firebase core to gradle dependencies.");
                 debug("Play services version: " + request.getArg("var.android.playServicesVersion", ""));
                 debug("gradleDependencies before: "+request.getArg("gradleDependencies", ""));
-                request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-core:${var.android.firebaseCoreVersion}\"\n");
+
+                request.putArgument(
+                        "gradleDependencies",
+                        request.getArg("gradleDependencies", "") +
+                                "\n"+compile+" \"com.google.firebase:firebase-core:" +
+                                request.getArg("android.firebaseCoreVersion", playServicesVersion) + "\"\n"
+                );
                 debug("gradleDependencies after: "+request.getArg("gradleDependencies", ""));
             }
             if (!request.getArg("gradleDependencies", "").contains("com.google.firebase:firebase-messaging")) {
-                request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-messaging:${var.android.firebaseMessagingVersion}\"\n");
+                request.putArgument(
+                        "gradleDependencies",
+                        request.getArg("gradleDependencies", "") +
+                                "\n"+compile+" \"com.google.firebase:firebase-messaging:" +
+                                request.getArg("android.firebaseMessagingVersion", playServicesVersion) + "\"\n"
+                );
             }
         }