This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Dmytro/int 1847 UI improvement for target path folder selection #821
Merged
DmytroHryshyn
merged 8 commits into
main
from
dmytro/int-1847-ui-improvement-for-target-path-folder-selection
Jan 29, 2024
Merged
Dmytro/int 1847 UI improvement for target path folder selection #821
DmytroHryshyn
merged 8 commits into
main
from
dmytro/int-1847-ui-improvement-for-target-path-folder-selection
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWL
reviewed
Jan 15, 2024
GeorgeWL
reviewed
Jan 15, 2024
intuita-webview/src/codemodList/components/DirectorySelector.tsx
Outdated
Show resolved
Hide resolved
GeorgeWL
suggested changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see the purpose of this PR tbh
DmytroHryshyn
force-pushed
the
dmytro/int-1847-ui-improvement-for-target-path-folder-selection
branch
from
January 29, 2024 10:42
cc31685
to
1dfcd9b
Compare
DmytroHryshyn
changed the title
DRAFT: Dmytro/int 1847 UI improvement for target path folder selection
Dmytro/int 1847 UI improvement for target path folder selection
Jan 29, 2024
hbjORbj
approved these changes
Jan 29, 2024
grzpab
reviewed
Jan 29, 2024
package.json
Outdated
@@ -271,7 +271,7 @@ | |||
"eslint": "^8.31.0", | |||
"eslint-config-prettier": "^8.6.0", | |||
"eslint-plugin-prettier": "^4.2.1", | |||
"glob": "^8.0.3", | |||
"glob": "^10.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we update the version, I think we should switch to fast-glob
grzpab
approved these changes
Jan 29, 2024
DmytroHryshyn
deleted the
dmytro/int-1847-ui-improvement-for-target-path-folder-selection
branch
January 29, 2024 14:54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast from 29.01.24 14:41:14.webm