This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
chore: add codemod-registry Windows support #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmytroHryshyn
changed the title
DmytroHryshyn
force-pushed
the
feat/add-codemods-windows-support
branch
from
d7e376b
to
66baca3
Compare
grzpab
reviewed
Jan 17, 2024
| @@ -687,6 +818,8 @@ describe('next 13 app-directory-boilerplate', function () { | |||
| '/opt/project/pages/a/b/c.tsx': index, | |||
| }); | |||
|
|
|||
| console.log([upsertPageCommand, _, deleteFileCommand], '???'); | |||
There was a problem hiding this comment.
can you remove this comment?
| @@ -210,6 +210,136 @@ describe('next 13 app-directory-boilerplate', function () { | |||
| ); | |||
| }); | |||
|
|
|||
| // Windows | |||
| // it.only('should build correct files', async function () { | |||
There was a problem hiding this comment.
do you think we could run it in the CI/CD with a CLI flag? how much effort would that be?
grzpab
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Replaces
path.posixwithpathfor compatibility with Windows.Fixes app-dir-boilerpalte