-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/logout signin pages #169
base: main
Are you sure you want to change the base?
Conversation
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
f0f8c83
to
6a48e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything ok except the changes here:
apps/web/app/AppDirSSRHOC.tsx
e0bc9f9
to
da15955
Compare
da15955
to
838c301
Compare
> I'm in the core Team of inlang ## Fix inlang's configuration file We changed the `project.inlang.json` to a `settings.json` in a `project.inlang` dir. This enables the inlang project to store app information or metadata in a dir that is not relevant to you as an end user. #### Old ```tree ├── project.inlang.json ``` #### New ```tree ├── project.inlang │ ├── settings.json ```
) Co-authored-by: Benny Joo <[email protected]>
838c301
to
49a2352
Compare
This PR is being marked as stale due to inactivity. |
What does this PR do?
This PR migrates the /auth/logout and /auth/signin pages to use the app directory (which runs under the App Router).
Migrated page exist under
/future/auth/*
and is accessible at all times.Type of change
How should this be tested?
Pages performance can be accessed via their individual URLs and various metrics could be validated to be improved compared to the previous implementation.
Mandatory Tasks
Checklist