Issue #2 Check fp only when necessary

codemix · Feb 16, 2017 · e622a8f · e622a8f
1 parent c813820
commit e622a8f
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/Target.php b/src/Target.php
@@ -48,15 +48,16 @@ public function init() {
             }
             $this->fp = @fopen($this->url,'w');
             if ($this->fp===false) {
-                throw new InvalidConfigException("Unable to append to '{$this->url}'");
+                throw new InvalidConfigException("Unable to open '{$this->url}' for writing.");
+            }
+        } else {
+            if (!is_resource($this->fp)) {
+                throw new InvalidConfigException("Invalid resource.");
+            }
+            $metadata = stream_get_meta_data($this->fp);
+            if ($metadata['mode']!=='w') {
+                throw new InvalidConfigException("Resource is not writeable.");
             }
-        }
-        if (!is_resource($this->fp)) {
-            throw new InvalidConfigException("Invalid resource.");
-        }
-        $metadata = stream_get_meta_data($this->fp);
-        if ($metadata['mode']!=='w') {
-            throw new InvalidConfigException("Resource is not writeable.");
         }
     }