Support dns aliases #203
Support dns aliases #203
Conversation
Config now accepts a new directive: alias
Multiple aliases can be separated by a comma
Special characters are:
*: Will match one subpath
**: Will match any subpaths
|
Thank you for the PR. I will merge this shortly. I am just brooding over the way this is exposed in ini files and if there can be a better way. |
| Invoker.dns_cache = Invoker::DNSCache.new(nil) | ||
|
|
||
| match = rewriter.select_backend_config('baz.dev') | ||
| expect(match.port).to eql(2) |
There was a problem hiding this comment.
The original domain is api.foo and specifying an alias of * takes over a unrelated domain baz.dev. So what happens if more than one entry specifies * alias?
There was a problem hiding this comment.
right now, the first entry with * will match and any others will be ignored.
|
I am not sure about allowing wildcard implementation that allows "*" and enables user to take over a unrelated domain. It depends on order of processing and can be somewhat unpredictable. May be we should consider disallowing "*" wildcard. |
|
thanks @gnufied for looking at it. I've lost interest in this feature (changed jobs) so feel free to close. thanks, |
|
@bhenderson thanks for opening the PR. Apologies about rather delayed review cycle. :( |
Adds support for domain alias lookup. Fixes #202
Config now accepts a new directive: alias
Multiple aliases can be separated by a comma
Special characters are:
*: Will match one subpath
**: Will match any subpaths
Let me know what you think.
thanks,