Add a cli option to specify backend services host if they are not running locally #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning locally. * e.g. Services running in Docker containers on Mac OS X need to be accessed via Docker VM IP address instead of OS X's localhost.
|
This makes ton of sense. @flanker I just merged https://github.com/code-mancers/invoker/pull/146/files which implements this partly. Can you update this branch with latest master? I will be happy to look and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker VM IP address instead of OS X's localhost.
On Mac OS X, dockerized services are not running as localhost. They need to be accessed via Docker VM (boot2docker or Docker machine) which usually has a different IP (e.g. 192.168.59.103)
Added this cli option to specify the backend service host. So the proxy could find the correct backend service.