Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for processes that are inactive by default #114

Merged
merged 5 commits into from
Nov 16, 2014

Conversation

nisanthchunduru
Copy link
Contributor

Ability to list a process in invoker.ini, but not have it autostarted by default

[postgres]
command = postgres -D /usr/local/var/postgres

[redis]
command = redis-server /usr/local/etc/redis.conf

[elasticsearch]
command = elasticsearch -f
autostart = false

add command can be used to start inactive processes later

invoker add elasticsearch

@gnufied
Copy link
Contributor

gnufied commented Nov 16, 2014

Looks great, the problem is - autostart = false and autostart=nil have opposite meanings. Perhaps, the flag should have a name which is more suitable for backward compatiblity - disable_autorun.

This way - only processes for which disable_autorun is true will not autorun on start. It will probably make code somewhat simpler as well.

@gnufied
Copy link
Contributor

gnufied commented Nov 16, 2014

Fixes, #67

@nisanthchunduru
Copy link
Contributor Author

@gnufied disable_autorun is a better name, will add the commits.

@nisanthchunduru
Copy link
Contributor Author

@gnufied Done. Renamed the flag to disable_autorun.

gnufied pushed a commit that referenced this pull request Nov 16, 2014
Support for processes that are inactive by default
@gnufied gnufied merged commit c3212c5 into codemancers:master Nov 16, 2014
@gnufied
Copy link
Contributor

gnufied commented Nov 16, 2014

Thank you for your contribution @nisanth074 . If you would like to help us in maintaining invoker - I can add you as a contributor. Thank you for making Invoker better than before.

@nisanthchunduru
Copy link
Contributor Author

@gnufied That would be great. Please add me as a collaborator/contributor
to the repo. Thanks.

On Monday, November 17, 2014, Hemant Kumar [email protected] wrote:

Thank you for your contribution @nisanth074
https://github.com/nisanth074 . If you would like to help us in
maintaining invoker - I can add you as a contributor. Thank you for making
Invoker better than before.


Reply to this email directly or view it on GitHub
#114 (comment).

@gnufied
Copy link
Contributor

gnufied commented Jan 10, 2015

Hey @nisanth074 I have given you commit access to Invoker. Feel free to work on any feature you feel comfortable with.

@nisanthchunduru nisanthchunduru deleted the autostart_option branch July 29, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants