Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python v3.13 #441

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

mohammedbabelly20
Copy link
Contributor

@mohammedbabelly20 mohammedbabelly20 commented Nov 20, 2024

Support Python 3.13, deprecate Python 3.7, and Python 3.8 is now the minimum version of Python required.
cffi has been updated to 1.17.1 as well.

@mohammedbabelly20 mohammedbabelly20 marked this pull request as ready for review November 20, 2024 12:16
Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise usages of typing_extensions in code. I think we're only importing Literal and Protocol from there; both of which were added to stdlib's typing module in Python 3.8. Altogether this means we can probably remove this dev-dependency too.

CHANGELOG.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
priitlatt
priitlatt previously approved these changes Nov 20, 2024
Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Edit: Dismissed

@priitlatt priitlatt dismissed their stale review November 20, 2024 14:45

Found tangling Python 3.7 reference

Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes are necessary:

Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in b234000 seems to resolve the remaining issues from #441 (review).

So looks good again. Hopefully permanently this time.

@mohammedbabelly20 mohammedbabelly20 merged commit ade2d13 into master Nov 21, 2024
13 checks passed
@mohammedbabelly20 mohammedbabelly20 deleted the improvement/support-python3.13 branch November 21, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants