-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python v3.13 #441
Support Python v3.13 #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revise usages of typing_extensions
in code. I think we're only importing Literal
and Protocol
from there; both of which were added to stdlib's typing
module in Python 3.8. Altogether this means we can probably remove this dev-dependency too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Edit: Dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes are necessary:
- Readme suggests that Python 3.7 is minimum supported version:
Line 15 in dcda8b5
The package requires Python version 3.7+. - Some cleanup can be done in
codemagic.apple.app_store_connect.resource_manager
:cli-tools/src/codemagic/apple/app_store_connect/resource_manager.py
Lines 59 to 60 in dcda8b5
# TODO: Once Python 3.7 support is removed and we have Protocols # available in runtime, then those can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in b234000 seems to resolve the remaining issues from #441 (review).
So looks good again. Hopefully permanently this time.
Support Python
3.13
, deprecate Python3.7
, and Python3.8
is now the minimum version of Python required.cffi
has been updated to1.17.1
as well.