Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deprecated relations on App resource optional #439

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Make deprecated relations on App resource optional #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee8dab2
Make deprecated relations on App resource optional
priitlatt Nov 7, 2024
01dbb32
Merge branch 'master' of github.com:codemagic-ci-cd/cli-tools into bu…
priitlatt Nov 7, 2024
e711a4e
Update changelog
priitlatt Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Version 0.54.3

**Bugfixes**
- Support device class `APPLE_SILICON_MAC` on App Store Connect API [`Device`](https://developer.apple.com/documentation/appstoreconnectapi/device) responses. [PR #437](https://github.com/codemagic-ci-cd/cli-tools/pull/437)
- Make undocumented `preOrder` and deprecated `inAppPurchases` relationships on App Store connect https://developer.apple.com/documentation/appstoreconnectapi/app/relationships-data.dictionary model optional . [PR #439](https://github.com/codemagic-ci-cd/cli-tools/pull/439)

**Improvements**
- Fail action `app-store-connect fetch-signing-files` early with descriptive error message if bundle ID identifier is not given. [PR #438](https://github.com/codemagic-ci-cd/cli-tools/pull/438)
Expand Down
4 changes: 2 additions & 2 deletions src/codemagic/apple/resources/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ class Relationships(Resource.Relationships):
builds: Relationship
endUserLicenseAgreement: Relationship
gameCenterEnabledVersions: Relationship
inAppPurchases: Relationship
preOrder: Relationship
preReleaseVersions: Relationship

alternativeDistributionKey: Optional[Relationship] = None
Expand All @@ -98,9 +96,11 @@ class Relationships(Resource.Relationships):
ciProduct: Optional[Relationship] = None
customerReviews: Optional[Relationship] = None
gameCenterDetail: Optional[Relationship] = None
inAppPurchases: Optional[Relationship] = None
inAppPurchasesV2: Optional[Relationship] = None
marketplaceSearchDetail: Optional[Relationship] = None
perfPowerMetrics: Optional[Relationship] = None
preOrder: Optional[Relationship] = None
pricePoints: Optional[Relationship] = None
promotedPurchases: Optional[Relationship] = None
reviewSubmissions: Optional[Relationship] = None
Expand Down
Loading