Skip to content

Commit

Permalink
remove unnecessary Protocol implementations
Browse files Browse the repository at this point in the history
  • Loading branch information
mohammedbabelly20 committed Nov 20, 2024
1 parent 4b1c87d commit b234000
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ and can be installed and updated using [pip](https://pip.pypa.io/en/stable/getti
python -m pip install codemagic-cli-tools
```

The package requires Python version 3.7+.
The package requires Python version 3.8+.

# Command line usage

Expand Down
18 changes: 0 additions & 18 deletions src/codemagic/apple/app_store_connect/resource_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,6 @@ class ModifyingResourceManager(PResourceManager[R_co], Protocol):
def modify(self, ref: ResourceReference, **update_params) -> R_co:
...

else:
# TODO: Once Python 3.7 support is removed and we have Protocols
# available in runtime, then those can be removed.
class CreatingResourceManager(Generic[R]):
...

class ReadingResourceManager(Generic[R]):
...

class ListingResourceManager(Generic[R]):
...

class DeletingResourceManager(Generic[R]):
...

class ModifyingResourceManager(Generic[R]):
...


class ResourceManager(Generic[R], metaclass=abc.ABCMeta):
class Filter:
Expand Down

0 comments on commit b234000

Please sign in to comment.