Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mohammed Babelly <[email protected]>
  • Loading branch information
priitlatt and mohammedbabelly20 authored Aug 8, 2024
1 parent 67510d9 commit 069cf4d
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/codemagic/models/xctests/xcresulttool.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ class XcResultTool(RunningCliAppMixin, StringConverterMixin):
@classmethod
@lru_cache(1)
def get_tool_version(cls) -> Optional[Version]:
# Cache the return value as it is not expected that chosen Xcode version,
# and consequently xcresulttool version, is changed during the execution
# of the action which requires xcresulttool. As there are possibly quite
# a few xcresulttool invocations for which we also need to know the used
# version, it is better to do the version check only once.
# Cache xcresulttool version to avoid repeated checks.
# Assumes Xcode (and thus xcresulttool) version remains constant during execution.

cmd_args = ["xcrun", "xcresulttool", "version"]
try:
Expand Down

0 comments on commit 069cf4d

Please sign in to comment.