Fix sso oic OpenIdConnectAuthenticator #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marevol and @hi-yamap, thanks for this MR, I've tested it out and it so far it looks like it's resolved my OIDC SSO issues. It looks like this has introduced a regression if groups are included in the JWT claim. I'm testing against the latest snapshot docker image. A sanitised version of JWT claim looks like this (using okta) You can see the groups claim is an array of groups as you'd expect, but it looks like the logic to build a string array was removed in this MR. Currently my workaround is to ensure the groups key is not present in the claim, which works but means I'm unable to map permissions. |
|
The implementation was modified to enable parsing of mixed-type arrays, which changed the type of private Object parseArray(JsonParser jsonParser) throws IOException {
List<Object> list = new ArrayList<>();
while (jsonParser.nextToken() != JsonToken.END_ARRAY) {
if (jsonParser.getCurrentToken() == JsonToken.START_OBJECT) {
list.add(parseObject(jsonParser));
} else if (jsonParser.getCurrentToken() == JsonToken.START_ARRAY) {
list.add(parseArray(jsonParser)); // Nested array
} else {
list.add(parsePrimitive(jsonParser));
}
}
if (list.stream().allMatch(String.class::isInstance)) {
return list.toArray(new String[list.size()]);
}
return list;
} |
|
Hey @hi-yamap, are you happy to put through a pull request for this? I can if not, would be good to fix this, as a list of groups seems pretty common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues that occurred when using single sign-on with AWS Cognito.
https://discuss.codelibs.org/t/openid-sso/2467