Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] fix japanese content into right meaning. #474

Merged

Conversation

zigzagdev
Copy link
Contributor

@zigzagdev zigzagdev commented Jan 15, 2025

Supersedes #473

Description

  • before text is wrong in japanese grammer. So, i fixed it.
  • And i opened the same PR before, but i made a mistake in before PR. So, i open the new one.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title fix japanese content into right meaning. [ja] fix japanese content into right meaning. Jan 16, 2025
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zigzagdev
Copy link
Contributor Author

@kenjis

Hi!🙌

Thanks to reviewing my PR.
But some github actions are failed. Is there anything to do for me about it??

@kenjis
Copy link
Member

kenjis commented Jan 16, 2025

This PR has no problem.

"code style / Code Style Check" fails because some code has been invalid style. Probably cs-fixer rules are updated.
If you want to fix the checks, please send another PR for it.

@paulbalandan paulbalandan merged commit 67f24a0 into codeigniter4:develop Jan 26, 2025
7 of 10 checks passed
@zigzagdev zigzagdev deleted the feature/japanese-translate-1 branch January 27, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants