Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove draft condition in mergeable #9439

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

paulbalandan
Copy link
Member

Description
The filter conditions were executed as OR, so if any filter passes it starts commenting PRs as if they are coming from first time contributors.
Tested: paulbalandan/b40d520f57f086f2e58d1f21d093935d#9

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@codeigniter4 codeigniter4 deleted a comment from mergeable bot Jan 29, 2025
@paulbalandan paulbalandan merged commit 74a7861 into codeigniter4:develop Jan 30, 2025
3 checks passed
@paulbalandan paulbalandan deleted the remove-draft-cond branch January 30, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants