Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix phpstan function.inner #9377

Merged
merged 1 commit into from
Jan 6, 2025
Merged

refactor: Fix phpstan function.inner #9377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/system/CommonHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,13 @@ public function testHelperLoadsAppHelperFirst(): void

// this chunk is not needed really; just added so that IDEs will be happy
if (! function_exists('foo_bar_baz')) {
function foo_bar_baz(): string
function foo_bar_baz(): string // @phpstan-ignore function.inner
{
return __FILE__;
}
}

$this->assertSame($this->dummyHelpers[0], foo_bar_baz()); // @phpstan-ignore-line function.notFound
$this->assertSame($this->dummyHelpers[0], foo_bar_baz()); // @phpstan-ignore function.notFound
}

public function testNamespacedHelperNotFound(): void
Expand Down
8 changes: 0 additions & 8 deletions utils/phpstan-baseline/function.inner.neon
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ includes:
- empty.property.neon
- expr.resultUnused.neon
- function.alreadyNarrowedType.neon
- function.inner.neon
- generator.valueType.neon
- isset.offset.neon
- isset.property.neon
Expand Down
Loading