Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forge::dropColumn() always returns false on SQLite3 driver #9351

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

paulbalandan
Copy link
Member

Description
Fixes #8849
Replaces and closes #8931

Changes are coming from the original PR. Not sure if there's anymore needed for this fix.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Dec 30, 2024
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a changelog entry.

@paulbalandan paulbalandan merged commit d7ce2ba into codeigniter4:develop Dec 31, 2024
42 checks passed
@paulbalandan paulbalandan deleted the forge-drop-column branch December 31, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(SQLite3): Forge::dropColumn() seems to always return false
3 participants