Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add @throws RedirectException in Controller::initController #9327

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Dec 16, 2024

Description
The underlying force_https may throw RedirectException

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan changed the title refactor: add @throws RedirectException in `Controller::initControl… refactor: add @throws RedirectException in Controller::initController Dec 16, 2024
system/Controller.php Outdated Show resolved Hide resolved
@paulbalandan paulbalandan force-pushed the remove-dead-catch branch 2 times, most recently from 3418ab1 to 72cc758 Compare December 19, 2024 04:34
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 19, 2024
@paulbalandan paulbalandan merged commit cc1b8f2 into codeigniter4:develop Dec 19, 2024
40 checks passed
@paulbalandan paulbalandan deleted the remove-dead-catch branch December 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants