Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix link in fix-label-add-conflict-all-pr.yml #9155

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: fix link in fix-label-add-conflict-all-pr.yml #9155

merged 1 commit into from
Aug 28, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2024 •
edited
Loading

Description
This workflow comments to PRs with conflicts. So it is better to link to "Updating Your Branch".

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
chore: fix link
982f995 
This workflow comments to PRs with conflicts. So it is better
to link to "Updating Your Branch".
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Aug 27, 2024
datamweb
datamweb approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@samsonasik samsonasik merged commit 2f78165 into codeigniter4:develop Aug 28, 2024
3 checks passed
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-label-add-conflict-all-pr.yml branch August 28, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@datamweb datamweb datamweb approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @samsonasik @datamweb @ddevsr