Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: small fixes in upgrade responses.rst #8815

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 21, 2024

Description

  • change page title
  • fix typo

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

kenjis added 3 commits April 21, 2024 10:49
This page is for CI3 users. In CI3 there is no HTTP Response.
So it is better to be "Upgrade Output Class".
@kenjis kenjis added the documentation Pull requests for documentation only label Apr 21, 2024
Comment on lines -257 to +258
upgrade_pagination
upgrade_responses
upgrade_pagination
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I assume this was alphabetical.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I changed the page title.
Screenshot 2024-04-23 6 26 33

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output class makes more sense from the perspective of a CI3 user.

@kenjis kenjis merged commit d47eccf into codeigniter4:develop Apr 30, 2024
3 checks passed
@kenjis kenjis deleted the docs-upgrade_responses.rst branch April 30, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants