refactor: create spark.php in system/, require by spark

[samsonasik]

Description

Reduce repetitive copy paste manual when run composer update.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[samsonasik]

Ready to review 👍 , we can have index.php in system as well in separate PR if this is accepted so reduce more manual upgrade.

[kenjis]

I don't think we need to have index.php in system.

1. CI4 is slower than CI3. So I don't want to increase the file to load.
2. We have created Boot class. So now index.php will not be broken as before.

[kenjis]

Oh, we cannot modify system/spark.php.
How do we do?

[samsonasik]

Oh, I see, the idea is to reduce manual change

The another way is make php requirment in single file under system, can also read CodeIgniter composer.json (yes, it make another include/read file, but reduce maintenance needs), eg: system/requirement.php so it included in both spark and public/index.php so once requirement change, it will only require composer up

[samsonasik]

Another way is make app/Config/Paths.php as an .env value, eg

APP_CONFIG_PATHS = "app/Config/Paths.php"

so it configurable there, default no data, fallback to default path

[kenjis]

I think including system/requirement.php is better.

[samsonasik]

Actually, $paths->systemDirectory is not needed here, as already inside the directory, I will create new commit.

[samsonasik]

Oh, it needed on exit(Boot::bootSpark($paths)); as pass Paths object

[kenjis]

We need the Paths instance first.
.env is loaded in Boot class.

[samsonasik]

I see, closing for now.

[MGatner]

I like the concept but I see the issues with implementation. Not opposed to another attempt but I think @kenjis' recent changes to Boot help a lot already.