fix: move Kint loading to Autoloader #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
bug
kenjis
force-pushed
the
fix-move-kint-autoload
branch
2 times, most recently
from
800a39a to
0d70fb8
Compare
This was referenced Mar 4, 2024
Merged
kenjis
added
the
breaking change
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
fix-move-kint-autoload
branch
from
0d70fb8 to
6ca5c66
Compare
kenjis
force-pushed
the
fix-move-kint-autoload
branch
from
6ca5c66 to
2df2f93
Compare
MGatner
requested changes
Mar 15, 2024
| define('TESTPATH', realpath(rtrim($paths->testsDirectory, '\\/ ')) . DIRECTORY_SEPARATOR); | ||
| } | ||
|
|
||
| /* | ||
| * --------------------------------------------------------------- | ||
| * GRAB OUR CONSTANTS & COMMON | ||
| * GRAB OUR CONSTANTS | ||
| * --------------------------------------------------------------- | ||
| */ | ||
|
|
||
| if (! defined('APP_NAMESPACE')) { |
There was a problem hiding this comment.
Won't this always be defined because it was required for the Autoloader?
public $psr4 = [
APP_NAMESPACE => APPPATH, // For custom app namespace
'Config' => APPPATH . 'Config',
];There was a problem hiding this comment.
It is defined in app/Config/Constants.php.
The value is set by phpnit.xml.dist, and there is no need to change baseURL.
It is done in `Services::autoload()->initialize()`.
This was in CodeIgniter::initialize(), so it was called only in web.
CONFIGPATH was not defined yet.
Co-authored-by: MGatner <[email protected]>
Co-authored-by: MGatner <[email protected]>
kenjis
force-pushed
the
fix-move-kint-autoload
branch
from
b5dea64 to
458333c
Compare
MGatner
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #8558
CodeIgniter::initializeKint()to AutoloaderCodeIgniter::initializeKint()registers an autoloader. So it is better to be in Autoloader.The following items are also needed, so included in this PR:
CodeIgniter::bootstrapEnvironment()to bootstrap.phpServices::exceptions()->initialize()to bootstrap.phpCodeIgniter::resolvePlatformExtensions()to bootstrap.phpChecklist: