-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove deprecated properties and methods in CodeIgniter class #8050
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
42b75cb
docs: add doc comments
kenjis 21e8f25
refactor: move forceSecureAccess() call
kenjis b20204a
refactor: move spoofRequestMethod() into getRequestObject()
kenjis 21760f6
docs: add @deprecated version
kenjis 4a63685
refactor!: remove deprecated properties and methods
kenjis 3519bdd
refactor: remove unneeded method_exist() check
kenjis f2806b3
refactor: make determinePath() deprecated
kenjis 94c4232
docs: add changelog
kenjis dd952f4
chore: update phpstan-baseline
kenjis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repeat of this and the fact that
spoofRequestMethod()
only works on the Request object itself makes me think this should eventually be moved into IncomingRequest. This could be a constructor override or a feature ofgetMethod()
(and maybe addinggetRawMethod()
or something?) or a new method likegetMethodWithSpoofing()
. That would also make an easy, central place to have this be configurable for security purposes: turn on/off, allow-list of methods, etc.For this PR I think what you have is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code, it is indeed all operations to the Request object.
CodeIgniter4/system/CodeIgniter.php
Lines 1027 to 1044 in 091abaf