Merge pull request #9342 from paulbalandan/new-static

refactor: fix warning on new static usage
codeigniter4 · Dec 28, 2024 · e363f47 · e363f47
2 parents 6cbbf60 + 2114577
commit e363f47
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/tests/_support/Entity/CustomUser.php b/tests/_support/Entity/CustomUser.php
@@ -26,7 +26,7 @@
  * @property string    $name
  * @property Time|null $updated_at
  */
-class CustomUser
+final class CustomUser
 {
     private function __construct(
         private readonly int $id,
@@ -40,7 +40,7 @@ private function __construct(
 
     public static function reconstruct(array $data): static
     {
-        return new static(
+        return new self(
             $data['id'],
             $data['name'],
             $data['email'],

diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -43,7 +43,6 @@ includes:
     - missingType.parameter.neon
     - missingType.property.neon
     - missingType.return.neon
-    - new.static.neon
     - notIdentical.alwaysTrue.neon
     - nullCoalesce.expr.neon
     - nullCoalesce.property.neon

diff --git a/utils/phpstan-baseline/new.static.neon b/utils/phpstan-baseline/new.static.neon