refactor: returns null on DebugToolbar and HoneyPot

codeigniter4 · Dec 21, 2024 · 88862ad · 88862ad
1 parent e8178eb
commit 88862ad
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 14 deletions.
diff --git a/system/Filters/DebugToolbar.php b/system/Filters/DebugToolbar.php
@@ -43,6 +43,6 @@ public function after(RequestInterface $request, ResponseInterface $response, $a
     {
         service('toolbar')->prepare($request, $response);
 
-        return $response;
+        return null;
     }
 }
diff --git a/system/Filters/Honeypot.php b/system/Filters/Honeypot.php
@@ -55,6 +55,6 @@ public function after(RequestInterface $request, ResponseInterface $response, $a
     {
         service('honeypot')->attachHoneypot($response);
 
-        return $response;
+        return null;
     }
 }
diff --git a/utils/phpstan-baseline/missingType.iterableValue.neon b/utils/phpstan-baseline/missingType.iterableValue.neon
@@ -1,4 +1,4 @@
-# total 1673 errors
+# total 1672 errors
 
 parameters:
     ignoreErrors:
@@ -4707,11 +4707,6 @@ parameters:
             count: 1
             path: ../../system/Language/Language.php
 
-        -
-            message: '#^Method CodeIgniter\\Language\\Language\:\:load\(\) return type has no value type specified in iterable type array\.$#'
-            count: 1
-            path: ../../system/Language/Language.php
-
         -
             message: '#^Method CodeIgniter\\Language\\Language\:\:parseLine\(\) return type has no value type specified in iterable type array\.$#'
             count: 1

diff --git a/utils/phpstan-baseline/return.missing.neon b/utils/phpstan-baseline/return.missing.neon
@@ -1,12 +1,7 @@
-# total 2 errors
+# total 1 error
 
 parameters:
     ignoreErrors:
-        -
-            message: '#^Method CodeIgniter\\Images\\Handlers\\BaseHandler\:\:__call\(\) should return mixed but return statement is missing\.$#'
-            count: 1
-            path: ../../system/Images/Handlers/BaseHandler.php
-
         -
             message: '#^Method CodeIgniter\\Test\\Mock\\MockResult\:\:fetchAssoc\(\) should return mixed but return statement is missing\.$#'
             count: 1