Merge pull request #8991 from samsonasik/refactor-phpunit-assert-object

refactor: using phpunit 10 assertObjectHasNotProperty() and assertObjectHasProperty()
codeigniter4 · Jun 23, 2024 · 61d2742 · 61d2742
2 parents 4e68814 + 3ab0644
commit 61d2742
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/system/Config/BaseConfigTest.php b/tests/system/Config/BaseConfigTest.php
@@ -131,7 +131,7 @@ public function testEnvironmentOverrides(): void
         // override config with shortPrefix ENV var
         $this->assertSame('hubbahubba', $config->delta);
         // incorrect env name should not inject property
-        $this->assertFalse(property_exists($config, 'notthere'));
+        $this->assertObjectNotHasProperty('notthere', $config);
         // empty ENV var should not affect config setting
         $this->assertSame('pineapple', $config->fruit);
         // non-empty ENV var should overrideconfig setting

diff --git a/tests/system/Test/FabricatorTest.php b/tests/system/Test/FabricatorTest.php
@@ -413,7 +413,7 @@ public function testCreateMockSetsDatabaseFields(): void
         $this->assertIsInt($result->created_at);
         $this->assertIsInt($result->updated_at);
 
-        $this->assertTrue(property_exists($result, 'deleted_at'));
+        $this->assertObjectHasProperty('deleted_at', $result);
         $this->assertNull($result->deleted_at);
     }