fix: handle other behavior of sql server.

codeigniter4 · Apr 14, 2024 · 441b889 · 441b889
1 parent 78dc4b4
commit 441b889
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/system/Database/SQLSRV/Builder.php b/system/Database/SQLSRV/Builder.php
@@ -290,6 +290,15 @@ private function getFullName(string $table): string
         }
 
         if ($this->db->escapeChar === '"') {
+            if (str_contains($table, '.')) {
+                $dbInfo    = explode('.', $table);
+                $database  = str_replace('"', '', $dbInfo[0]);
+                $schema    = str_replace('"', '', $dbInfo[1]);
+                $tableName = str_replace('"', '', $dbInfo[2]);
+
+                return '"' . $database . '"."' . $schema . '"."' . str_replace('"', '', $tableName) . '"' . $alias;
+            }
+
             return '"' . $this->db->getDatabase() . '"."' . $this->db->schema . '"."' . str_replace('"', '', $table) . '"' . $alias;
         }
 

diff --git a/tests/system/Database/Builder/FromTest.php b/tests/system/Database/Builder/FromTest.php
@@ -153,4 +153,20 @@ public function testFromSubqueryWithSQLSRV(): void
 
         $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledSelect()));
     }
+
+    /**
+     * See https://github.com/codeigniter4/CodeIgniter4/issues/8697
+     *
+     * @return void
+     */
+    public function testConstructorWithMultipleSegmentTableWithSQLSRV(): void
+    {
+        $this->db = new MockConnection(['DBDriver' => 'SQLSRV', 'database' => 'test', 'schema' => 'dbo']);
+
+        $builder = new SQLSRVBuilder('database.dbo.table', $this->db);
+
+        $expectedSQL = 'SELECT * FROM "database"."dbo"."table"';
+
+        $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledSelect()));
+    }
 }