chore: move continue-on-error to reusable-phpunit-test.yml

codeigniter4 · Aug 21, 2024 · 312ffa0 · 312ffa0
1 parent 296c5a5
commit 312ffa0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/.github/workflows/reusable-phpunit-test.yml b/.github/workflows/reusable-phpunit-test.yml
@@ -203,6 +203,7 @@ jobs:
           DB: ${{ inputs.db-platform }}
           TACHYCARDIA_MONITOR_GA: ${{ inputs.enable-profiling && 'enabled' || '' }}
           TERM: xterm-256color
+        continue-on-error: ${{ inputs.php-version == '8.4' }}
 
       - name: Upload coverage results as artifact
         if: ${{ inputs.enable-artifact-upload }}

diff --git a/.github/workflows/test-phpunit.yml b/.github/workflows/test-phpunit.yml
@@ -62,7 +62,6 @@ jobs:
         include:
           - php-version: '8.4'
             composer-option: '--ignore-platform-req=php'
-            continue-on-error: true
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:
@@ -103,7 +102,6 @@ jobs:
             mysql-version: '5.7'
           - php-version: '8.4'
             composer-option: '--ignore-platform-req=php'
-            continue-on-error: true
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:
@@ -134,7 +132,6 @@ jobs:
         include:
           - php-version: '8.4'
             composer-option: '--ignore-platform-req=php'
-            continue-on-error: true
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:
@@ -163,7 +160,6 @@ jobs:
         include:
           - php-version: '8.4'
             composer-option: '--ignore-platform-req=php'
-            continue-on-error: true
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with: