Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java7 and Java8 improvements #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

herenyi
Copy link

@herenyi herenyi commented Feb 1, 2018

Added Java7 default method for interface and java8 lambdas and method references with tests

@herenyi
Copy link
Author

herenyi commented Jun 26, 2018

Added a fix and a test previously found by Cobertura

@hboutemy
Copy link

hboutemy commented Aug 7, 2019

@herenyi Thank you for your PR
but it is against wrong repository: this repository is read-only
can you update the PR against https://github.com/JavaNCSS/javancss please? I'll review and merge

@scordio
Copy link

scordio commented Aug 9, 2019

Hi @hboutemy, I created JavaNCSS#3 based on this one, it would be great if you could review. Thanks!
Sorry I underestimated the effort to apply these changes, there is an issue that I do not understand why it is happening and how I should fix it. I am going to close my PR and hopefully @herenyi will do a better job :-)

@herenyi
Copy link
Author

herenyi commented Aug 10, 2019

OK. I will create a new PR for that repository! By the way did you take over the maintenance from Clemens Lee and created this new repository?

@hboutemy
Copy link

I worked with Clemens a few years ago to put the code on Codehaus in 2008, where versions 30.51 to 33.54 were released. But Codehaus closed in 2015.
Then I moved the code to GitHub https://github.com/JavaNCSS/javancss without much communication, sorry: I recently added the corresponding site http://javancss.github.io
After merging your PR, I should soon release 34.55: if you have other improvements ideas, don't hesitate to share

@hazendaz
Copy link

hazendaz commented Nov 7, 2019

@herenyi Were you still going to create PR over on the new location? It would be nice to get a release out that works with lambdas...

@neo7BF
Copy link

neo7BF commented Jun 24, 2020

Where are you at with the working release for java 8 support ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants