back to vars

codeforsanjose · Feb 23, 2024 · bfd29b9 · bfd29b9
1 parent c7ef493
commit bfd29b9
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
@@ -17,10 +17,12 @@ concurrency:
 
 env:
   REFERENCE: ${{ github.event.pull_request.head.sha || github.event.push.head_commit.id }}
-  REACT_APP_API_SERVER: ${{ env.REACT_APP_API_SERVER != '' && env.REACT_APP_API_SERVER || vars.REACT_APP_API_SERVER }}
 
 jobs:
   build:
+    environment:
+      name: ${{ github.event.inputs.env }}
+      url: ${{ vars.PUBLIC_URL }}
     runs-on: ubuntu-latest
     permissions:
       id-token: write
@@ -45,10 +47,10 @@ jobs:
       - run: make build-${{ matrix.image }}
         env:
           AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}
-          LOG_LEVEL: ${{ env.SERVER_LOG_LEVEL != '' && env.SERVER_LOG_LEVEL || vars.SERVER_LOG_LEVEL }}
-          REACT_APP_API_SERVER: ${{ env.REACT_APP_API_SERVER }}
-          PUBLIC_URL: ${{ env.PUBLIC_URL != '' && env.PUBLIC_URL || vars.PUBLIC_URL }}
-          API_BASE_URL: ${{ env.API_BASE_URL != '' && env.API_BASE_URL || vars.API_BASE_URL }}
+          LOG_LEVEL: ${{ vars.SERVER_LOG_LEVEL }}
+          REACT_APP_API_SERVER: ${{ vars.REACT_APP_API_SERVER }}
+          PUBLIC_URL: ${{ vars.PUBLIC_URL }}
+          API_BASE_URL: ${{ vars.API_BASE_URL  }}
 
 
   deploy:
@@ -59,7 +61,7 @@ jobs:
       contents: read
     environment:
       name: ${{ github.event.inputs.env }}
-      url: ${{ env.PUBLIC_URL != '' && env.PUBLIC_URL || vars.PUBLIC_URL }}
+      url: ${{ vars.PUBLIC_URL }}
     env:
       ENVIRONMENT: ${{ github.event.inputs.env }}
     steps:
@@ -85,4 +87,4 @@ jobs:
           ARGO_CD_SERVER: ${{ secrets.ARGO_CD_SERVER }}
           ARGO_CD_USERNAME: ${{ secrets.ARGO_CD_USERNAME }}
           ARGO_CD_PASSWORD: ${{ secrets.ARGO_CD_PASSWORD }}
-          API_BASE_URL: ${{ env.API_BASE_URL != '' && env.API_BASE_URL || vars.API_BASE_URL }}
+          API_BASE_URL: ${{ vars.API_BASE_URL }}