-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documents of other administrative entities + json schema #147
base: master
Are you sure you want to change the base?
Changes from 1 commit
b79e39d
77df3ff
09aa795
03ae778
f904277
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,81 @@ | ||||||||
{ | ||||||||
"$schema": "http://json-schema.org/draft-06/schema#", | ||||||||
"$ref": "#/definitions/KlimawatchDocuments", | ||||||||
"definitions": { | ||||||||
"KlimawatchDocuments": { | ||||||||
"type": "object", | ||||||||
"properties": { | ||||||||
"data": { | ||||||||
"type": "array", | ||||||||
"items": { | ||||||||
"type": "object", | ||||||||
"properties": { | ||||||||
"entity": { | ||||||||
"$ref": "#/definitions/Entity" | ||||||||
}, | ||||||||
"documents": { | ||||||||
"type": "array", | ||||||||
"items": { | ||||||||
"$ref": "#/definitions/Document" | ||||||||
} | ||||||||
} | ||||||||
}, | ||||||||
"additionalProperties": false, | ||||||||
"required": ["entity", "documents"] | ||||||||
} | ||||||||
} | ||||||||
}, | ||||||||
"required": ["data"] | ||||||||
}, | ||||||||
"Entity": { | ||||||||
"title": "Gebietskörperschaft: Landkreis, Gemeinde, etc", | ||||||||
"type": "object", | ||||||||
"properties": { | ||||||||
"id": { | ||||||||
"type": "string" | ||||||||
}, | ||||||||
"name": { | ||||||||
"type": "string" | ||||||||
}, | ||||||||
"adminLevel": { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was bezeichnet There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Die Idee war das man den Daten direkt ansieht ob sie sich auf einen Landkreis, Stadt(-teil/bezirtk), Gemeine usw. beziehen. Ich hatte ihr einfach den Wert aus OSM übernommen, vgl. https://wiki.openstreetmap.org/wiki/Key:admin_level bzw. https://wiki.openstreetmap.org/wiki/DE:Grenze#Innerstaatliche_Grenzen
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oder wir machen nen Enum draus... |
||||||||
"type": "integer" | ||||||||
}, | ||||||||
"ags": { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was bezeichnet das Property There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Den Amtlichen Gemeindeschlüssel, also das Wikidata Property https://www.wikidata.org/wiki/Property:P439 – wir sollten vielleicht auch noch den ARS (Amtlicher Regionalschlüssel) mit aufnehmen, vgl. https://openknowledgegermany.slack.com/archives/CQC9RQ1NU/p1635673845027400?thread_ts=1635672345.022800&cid=CQC9RQ1NU allerdings fehlt der aktuell noch in Wikidata... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://de.wikipedia.org/wiki/Amtlicher_Gemeindeschlüssel#Regionalschlüssel
Okay, ich ging zu dem Zeitpunkt noch davon aus das AGS und ARS enger verwandt sind... können wir dann auch einfach rauslassen und statt dessen nur den ARS aufführen. |
||||||||
"type": "string" | ||||||||
}, | ||||||||
"wikidata": { | ||||||||
saerdnaer marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
"type": "string", | ||||||||
"format": "uri" | ||||||||
}, | ||||||||
"osm": { | ||||||||
saerdnaer marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
"type": "string", | ||||||||
"format": "uri" | ||||||||
} | ||||||||
}, | ||||||||
"required": ["name"] | ||||||||
}, | ||||||||
"Document": { | ||||||||
"title": "Document", | ||||||||
"description": "PDF Dokument oder Webseite, die den Klimaplan der Einheit beschreibt, Maßnamen auflistet und den Umsetzungsvorschritt evaluiert.", | ||||||||
saerdnaer marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
"type": "object", | ||||||||
"additionalProperties": false, | ||||||||
"properties": { | ||||||||
"title": { | ||||||||
"type": "string" | ||||||||
}, | ||||||||
"url": { | ||||||||
"type": "string", | ||||||||
"format": "uri" | ||||||||
}, | ||||||||
"type": { | ||||||||
"type": "string", | ||||||||
"enum": ["PLAN", "REPORT", "ACTIONLIST", "WEBSITE"] | ||||||||
}, | ||||||||
"comment": { | ||||||||
"type": "string" | ||||||||
} | ||||||||
}, | ||||||||
"required": ["url"] | ||||||||
} | ||||||||
} | ||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ist "Entity" hier nicht etwas sehr generisch? Wie wäre es mit "ReportingEntity" oder "RegionalAuthority" oder "ReportingRegionalAuthority"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja, weitere Alternativen wäre
AdminUnit
,AdministrativeUnit
,Region
oderArea
... Such dir einfach das aus was dir am besten gefällt :-)