Skip to content

Run cp and mv in QSH to keep CCSID attribute #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sebjulliand
Copy link
Collaborator

@sebjulliand sebjulliand commented May 28, 2025

Changes

Fixes #2696

As explained by @kadler in the IBM i OSS chat, QSH version of cp retain the CCSID of the original file into the copy.
Running the copy and move operations in QSH fixes the issue reported in #2696.

How to test this PR

  • Run the new test case
  • Check from the UI
    1. Create a streamfile with CCSID != 1208 or 819: touch -C 37 testfile
    2. Copy this streamfile using drag and drop in the IFS browser
    3. Copy it also using the right-click Copy action
    4. Check the CCSID of the copied file is 37: attr copyOfTestFile CCSID

Checklist

  • have tested my change

@sebjulliand sebjulliand requested a review from a team May 28, 2025 21:05
@sebjulliand sebjulliand self-assigned this May 28, 2025
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label May 28, 2025
Copy link
Contributor

github-actions bot commented May 28, 2025

👋 A new build is available for this PR based on 6077f1e.

@worksofliam
Copy link
Contributor

@sebjulliand do we have any test cases to check for this?

@worksofliam worksofliam added this to the 3.0.0 milestone May 29, 2025
@sebjulliand sebjulliand had a problem deploying to testing_environment May 29, 2025 21:26 — with GitHub Actions Failure
@sebjulliand
Copy link
Collaborator Author

@sebjulliand do we have any test cases to check for this?

@worksofliam now we do 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File copy and paste of IFS files do not maintain original encoding
2 participants