Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging and log parsing #2236

Closed
wants to merge 4 commits into from

Conversation

worksofliam
Copy link
Contributor

Changes

New changes to improve debugging user issues.

Add additional information to the output channel for us to capture better scenarios.

The new command parses the contents of the clipboard, assumed to be the output logs and generates a nicer looking document with:

  • runnable commands
  • readable output

How to test this PR

Examples:

  1. Copy to output channel to your clipboard
  2. Start debugging Code for IBM i and use the new 'Parse Output Channel logs' command

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam worksofliam added the ready Ready for review label Sep 3, 2024
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, it will certainly help analyzing the output.
What I don't like is the output isn't formatted anymore, which means it's harder to read unless you spin up a Code for i in debug mode (with tests enabled) and use the new command.

Maybe try to keep it formatted by default so it can still be easily read by anyone, even when pasted on GitHub.
Having to rely on a tool to read the logs will not make our lives easier 😅

@worksofliam
Copy link
Contributor Author

@sebjulliand Good point - I am going to close this and likely start it again since it's far behind now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants