Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the base API to allow other extensions to add their own components. #2232

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

worksofliam
Copy link
Contributor

Changes

Adds brand new export to the base API which allows other extensions to add their own installable components.

Components are checked on connection to ensure they are installed on the OS.

How to test this PR

Examples:

  1. Run the test cases
  2. Ensure extension starts up with existing components as usual.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@sebjulliand
Copy link
Collaborator

@worksofliam I tried to make the component's workflow as clear as possible for whoever would like to register a component.
Let me know what you think.

Question: would we want to keep track of which extension registers which component and be able to display a list of all the registered components (in the settings view, for example)?

@sebjulliand sebjulliand added the enhancement New feature or request label Sep 18, 2024
@sebjulliand
Copy link
Collaborator

Question: would we want to keep track of which extension registers which component and be able to display a list of all the registered components (in the settings view, for example)?

Forget it: yes we do.
image

@worksofliam give it a whirl 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants