Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Save password button on password prompt #2155

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

This PR adds a Save password and connect button on the password prompt shown when connecting to a system whose password is not stored.
image

When clicked, the password will be stored only if the connection is successful.

How to test this PR

  1. Connect to a system whose password is not stored
  2. Enter the password, press enter to connect
  3. Disconnect
  4. Connect again: the password prompt must show up again
  5. Press ESC
  6. Connect again: the password prompt must show up again
  7. Enter the password and click on Save password and connect
  8. Disconnect
  9. Connect again: the password prompt must not show up

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand sebjulliand added the enhancement New feature or request label Jul 9, 2024
@sebjulliand sebjulliand added this to the 2.12.0 milestone Jul 9, 2024
@sebjulliand sebjulliand self-assigned this Jul 9, 2024
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Great idea - bad implementation: There is no new button on the login prompt! 😄

@sebjulliand
Copy link
Collaborator Author

Oh dear, I forgot to push the commits 😅

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand LGTM - working as expected. 👍

Is it possible to fix the error popping up when creating a new connection without a password and pressing Connect?
billede

Not caused by your changes but still somehow related - and while you're at it...? 😉

@sebjulliand
Copy link
Collaborator Author

This is now fixed @chrjorgensen ; the same prompt will be used when connecting for the first time with a new connection.

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand You are the 🌟 ! I'm happy to approve! 😃

Merge at will...

@sebjulliand
Copy link
Collaborator Author

@sebjulliand You are the 🌟 ! I'm happy to approve! 😃

Merge at will...

Thank you mate!

@sebjulliand sebjulliand merged commit 4948181 into master Jul 9, 2024
1 check passed
@sebjulliand sebjulliand deleted the feature/savePasswordPrompt branch July 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants