-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Save password button on password prompt #2155
Conversation
Signed-off-by: Seb Julliand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand Great idea - bad implementation: There is no new button on the login prompt! 😄
Signed-off-by: Seb Julliand <[email protected]>
Oh dear, I forgot to push the commits 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand LGTM - working as expected. 👍
Is it possible to fix the error popping up when creating a new connection without a password and pressing Connect
?
Not caused by your changes but still somehow related - and while you're at it...? 😉
Signed-off-by: Seb Julliand <[email protected]>
This is now fixed @chrjorgensen ; the same prompt will be used when connecting for the first time with a new connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand You are the 🌟 ! I'm happy to approve! 😃
Merge at will...
Thank you mate! |
Changes
This PR adds a
Save password and connect
button on the password prompt shown when connecting to a system whose password is not stored.When clicked, the password will be stored only if the connection is successful.
How to test this PR
ESC
Save password and connect
Checklist