Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SEU colour support, add cleanup support #2192

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Remove SEU colour support, add cleanup support #2192

wants to merge 10 commits into from

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Jul 23, 2024 •
edited
Loading

Changes

Closes #2056.

Todo

  • Add translation for cleanup UI question ✅
  • Add test case ✅

How to test this PR

Create a member using SQL:

Click me 
CREATE OR REPLACE ALIAS ILEDITOR.LIAMA_QRPGLESRC_COLOURS for "LIAMA"."QRPGLESRC"("COLOURS");

delete from ILEDITOR.LIAMA_QRPGLESRC_COLOURS;

insert into ILEDITOR.LIAMA_QRPGLESRC_COLOURS (srcseq, srcdat, srcdta)
values 
  (01.00, 240805, '      // This illustrates 5250 attribute bytes.'),
  (02.00, 240805, '     '),
--(05.00, 240805, '     C*' concat x'XX' concat 'X''XX''' concat x'404020' concat  'X''XX'' GRN RI UL BL CS ND'),
  (03.00, 240805, '     C*' concat x'20' concat 'X''20''' concat x'404020' concat  'X''20'' GRN               '),
  (04.00, 240805, '     C*' concat x'24' concat 'X''24''' concat x'404020' concat  'X''24'' GRN    UL         '),
  (05.00, 240805, '     C*' concat x'25' concat 'X''25''' concat x'404020' concat  'X''25'' GRN RI UL         '),
  (06.00, 240805, '     C*' concat x'2E' concat 'X''2E''' concat x'404020' concat  'X''2E'' RED    UL BL      '),
  (07.00, 240805, '     C*' concat x'2F' concat 'X''2F''' concat x'404020' concat  'X''2F'' RED             ND'),
  (08.00, 240805, '     C*' concat x'30' concat 'X''30''' concat x'404020' concat  'X''30'' TRQ          CS   '),
  (09.00, 240805, '     C*' concat x'36' concat 'X''36''' concat x'404020' concat  'X''36'' YLW          CS   '),
  (10.00, 240805, '     C*' concat x'37' concat 'X''37''' concat x'404020' concat  'X''37'' YLW          CS ND'),
  (11.00, 240805, '     C*' concat x'3D' concat 'X''3D''' concat x'404020' concat  'X''3D'' PNK RI UL         '),
  (12.00, 240805, '     C*' concat x'3E' concat 'X''3E''' concat x'404020' concat  'X''3E'' BLU    UL         '),
  (13.00, 240805, '     C*' concat x'3F' concat 'X''3F''' concat x'404020' concat  'X''3F'' revert to default '),
  (14.00, 240805, '     '),
  (15.00, 240805, '       *inlr = *on;'),
  (16.00, 240805, '       return;')

Then open the member with Code for IBM i and expect to see the question for cleanup.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam worksofliam requested a review from a team July 23, 2024 14:23
@worksofliam worksofliam added this to the 3.0.0 milestone Jul 29, 2024
@worksofliam worksofliam changed the title Remove SEU colour support Remove SEU colour support, add cleanup support Aug 2, 2024
@worksofliam worksofliam linked an issue Aug 3, 2024 that may be closed by this pull request
Some 5250 attribute bytes are not preserved #2211
Open
@worksofliam worksofliam marked this pull request as draft August 7, 2024 14:24
@worksofliam worksofliam self-assigned this Aug 7, 2024
@worksofliam worksofliam marked this pull request as ready for review September 2, 2024 19:17
@worksofliam worksofliam added the ready Ready for review label Sep 3, 2024
This was linked to issues Sep 3, 2024
Line truncation when x'00' encountered in source member #1917
Closed
Show SEU Colors feature is overlaying characters #1490
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@worksofliam worksofliam

Labels
ready Ready for review
Projects
None yet
Milestone
3.0.0
1 participant
@worksofliam