Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swagger response body for user #67 #135

Closed
wants to merge 1 commit into from
Closed

add swagger response body for user #67 #135

wants to merge 1 commit into from

Conversation

iamsahebgiri
Copy link

Description

Added response body for user in swagger UI.

Related Issue

  • Document user controller

Fixes # [ISSUE]
#67

Type of Change:

  • Code
  • User Interface
  • New Feature
  • Documentation
  • Testing

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)

How Has This Been Tested?

Additional Info (OPTIONAL)

Checklist

  • My code follows the code style of this project.
  • My UI is responsive
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • My changes generate no new warnings
  • The title of my pull request is a short description of the requested changes.

Screenshots

Original Updated
Original Updated

Copy link
Collaborator

@Devesh21700Kumar Devesh21700Kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamsahebgiri APIproperty is not needed as the nest-cli automatically adds it from example comment

@iamsahebgiri
Copy link
Author

Thank you for your reply @Devesh21700Kumar.

But nest wasn't showing the response body, so I had to mention it explicitly. Please tell me if I am missing something.

@Devesh21700Kumar
Copy link
Collaborator

Thank you for your reply @Devesh21700Kumar.

But nest wasn't showing the response body, so I had to mention it explicitly. Please tell me if I am missing something.

yeah.. you have to tun the command nest start instead of npm start or npm run dev or any other command
That will compile the nest script correctly.

Lemme show you, (See the pic below)

image

@Devesh21700Kumar
Copy link
Collaborator

Thank you for your reply @Devesh21700Kumar.
But nest wasn't showing the response body, so I had to mention it explicitly. Please tell me if I am missing something.

yeah.. you have to tun the command nest start instead of npm start or npm run dev or any other command
That will compile the nest script correctly.

Lemme show you, (See the pic below)

image

feel free to ask any other doubt you might have regarding this

@iamsahebgiri
Copy link
Author

iamsahebgiri commented Aug 27, 2021

I totally get it. Now I will have to undo all the commits and then add comments to those classes which lack such comments if exists any.


After going through the entire codebase, I got to know that most of the work is already done. If there is any work that you want me to try then do let me know.

There are few questions though -

  • Why was the announcement and mentor routes are capitalized? Does it signify anything important?
  • Are you planning to add API versioning?
  • Any plans to update it to nestjs 8?

@Devesh21700Kumar
Copy link
Collaborator

Devesh21700Kumar commented Aug 28, 2021

I totally get it. Now I will have to undo all the commits and then add comments to those classes which lack such comments if exists any.

After going through the entire codebase, I got to know that most of the work is already done. If there is any work that you want me to try then do let me know.

There are few questions though -

  • Why was the announcement and mentor routes are capitalized? Does it signify anything important?
  • Are you planning to add API versioning?
  • Any plans to update it to nestjs 8?

Actually they don't have to be capitalised. They had to be converted to lowercase.

Haven't thought about the rest of them.

but you can do the APi versioning and bump to nestjs 8 if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants