Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1151 Update NC references to 2023 schema to 2024 schema #4966

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Nov 12, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

How to test?

  • no tests broke
  • test all fixtures & scan for any XML errors
    Noted my findings in jira comment. TL;DR: no glaring inconsistencies between the two schemas.

Copy link

Heroku app: https://gyr-review-app-4966-42450cd7f30b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4966 (optionally add --tail)

@arinchoi03 arinchoi03 changed the title FYST-1151 Update references to 2023 schema to 2024 schema FYST-1151 Update NC references to 2023 schema to 2024 schema Nov 13, 2024
Copy link
Contributor

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 you know i voted this a "1" but then realized i had no idea how to do it. 🫠 glad to see that it is fairly straight forward. thanks arin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants