-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expense calculator bug #259
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
src/main/java/org/mdbenefits/app/submission/actions/MaybeClearMoneyOnHandAmount.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package org.mdbenefits.app.submission.actions; | ||
|
||
import formflow.library.config.submission.Action; | ||
import formflow.library.data.FormSubmission; | ||
import formflow.library.data.Submission; | ||
import lombok.extern.slf4j.Slf4j; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Component | ||
@Slf4j | ||
public class MaybeClearMoneyOnHandAmount implements Action { | ||
|
||
/** | ||
* This action will clear out the expeditedMoneyOnHandAmount field, if the householdMoneyOnHandLessThan100 is equal to "true"; | ||
* This is useful in the case that the user goes forward and enters an amount and then goes back and indicates that they have | ||
* less than the money on hand threshold. | ||
* | ||
* @param formSubmission the data being submitted. | ||
* @param submission submission object the action is associated with, not null | ||
*/ | ||
@Override | ||
public void run(FormSubmission formSubmission, Submission submission) { | ||
boolean isMoneyOnHandLessThan100 = ((String) formSubmission.getFormData() | ||
.get("householdMoneyOnHandLessThan100")).equalsIgnoreCase("true"); | ||
|
||
if (isMoneyOnHandLessThan100) { | ||
formSubmission.getFormData().put("expeditedMoneyOnHandAmount", "0"); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,7 @@ flow: | |
nextScreens: | ||
- name: expeditedSnapMoneyOnHand | ||
expeditedSnapMoneyOnHand: | ||
onPostAction: MaybeClearMoneyOnHandAmount | ||
beforeSaveAction: CheckExpeditedSnapEligibility | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a new action to clear out the money amount in the event that they said they had money, but then went back and changed their mind on that. |
||
nextScreens: | ||
- name: expeditedSnapQualificationNotice | ||
|
@@ -270,6 +271,7 @@ flow: | |
condition: IsApplyingForSnap | ||
- name: householdMedicalExpenses | ||
householdMoneyOnHand: | ||
onPostAction: MaybeClearMoneyOnHandAmount | ||
beforeSaveAction: CheckExpeditedSnapEligibility | ||
nextScreens: | ||
- name: householdMoneyOnHandAmount | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spokenbird I changed this to "equalsIgnoreCase()" so that we still do the right thing if someone accidentally changes this to "NONE" or "none".