Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categories (goals) to SDG targets #2

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

andylolz
Copy link
Member

There’s a link between these two codelists, which it’s useful to be able to see on the reference site and elsewhere. The DAC (replicated) codelist includes this link as category elements.

Copy link

@matmaxgeds matmaxgeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a step forwards to me, only not approving because I don't have my head around what is possible to do with codelists in terms of what their structure enables, so can't tell if this is 'schema correct' or whatever the appropriate phrase it (or if we want to stick to that)

@andylolz
Copy link
Member Author

Cool – thanks for taking a look Matt!

So I sent the equivalent PR upstream here: IATI#304.

So for the IATI reference site, it adds references from SDG targets to their respective SDG goals:
http://sdg-categories-iati-codelists-nonembedded-refbot.surge.sh/codelists/UNSDG-Targets/#codes

On https://codelists.codeforiati.org, this would add a reference in the description, and categories, similar to those shown on the Sector codelist.

@matmaxgeds
Copy link

Thanks - good to see that it is used elsewhere (Sectors).....part of me feels that this hints about how the SDG Indicators (the third level, non-replicated to date) codelist should be setup.

@andylolz
Copy link
Member Author

andylolz commented Oct 28, 2019

Yep, agreed. It’s unclear why this wouldn’t also be replicated.

Copy link
Member

@markbrough markbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@markbrough markbrough merged commit 3965f06 into master Oct 31, 2019
@markbrough markbrough deleted the 305-sdg-target-categories branch October 31, 2019 12:16
@andylolz
Copy link
Member Author

andylolz commented Oct 31, 2019

Ace – so the categories are now shown here:
https://codelists.codeforiati.org/UNSDG-Targets/

Thanks for reviewing and merging, both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants