Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive the session.id/order_number from the upload.id #720

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

fix various foreign key column definitions

cdf4bba
Select commit
Loading
Failed to load commit list.
Draft

Derive the session.id/order_number from the upload.id #720

fix various foreign key column definitions
cdf4bba
Select commit
Loading
Failed to load commit list.
Codecov Notifications / codecov/project failed Sep 18, 2024 in 0s

90.63% (-7.44%) compared to 6ecd3ba

View this Pull Request on Codecov

90.63% (-7.44%) compared to 6ecd3ba

Details

Codecov Report

Attention: Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.

Files Patch % Lines
tasks/tests/integration/test_upload_e2e.py 8.33% 11 Missing ⚠️
tasks/upload_finisher.py 20.00% 8 Missing ⚠️
services/report/__init__.py 85.71% 1 Missing ⚠️
services/report/raw_upload_processor.py 94.44% 1 Missing ⚠️
tasks/upload_processor.py 83.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6ecd3ba) and HEAD (cdf4bba). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (6ecd3ba) HEAD (cdf4bba)
latest-uploader-overall 2 1
unit 2 1
integration 2 0

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   98.07%   90.63%   -7.44%     
==========================================
  Files         434      434              
  Lines       36734    36673      -61     
==========================================
- Hits        36027    33240    -2787     
- Misses        707     3433    +2726     
Components Coverage Δ
NonTestCode 90.23% <78.43%> (-5.75%) ⬇️
OutsideTasks 95.46% <94.44%> (-2.63%) ⬇️
Files Coverage Δ
database/models/reports.py 99.01% <100.00%> (-0.50%) ⬇️
helpers/parallel_upload_processing.py 23.80% <ø> (-61.91%) ⬇️
helpers/reports.py 92.30% <100.00%> (-7.70%) ⬇️
services/report/tests/unit/test_process.py 99.07% <100.00%> (ø)
tasks/tests/unit/test_upload_processing_task.py 73.70% <100.00%> (-26.30%) ⬇️
tasks/tests/unit/test_upload_task.py 54.07% <100.00%> (-45.02%) ⬇️
tasks/upload.py 70.98% <100.00%> (-25.35%) ⬇️
services/report/__init__.py 89.84% <85.71%> (-6.94%) ⬇️
services/report/raw_upload_processor.py 95.76% <94.44%> (+1.82%) ⬆️
tasks/upload_processor.py 90.41% <83.33%> (-9.01%) ⬇️
... and 2 more

... and 54 files with indirect coverage changes