Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop writing UploadLevelTotals #671

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Stop writing UploadLevelTotals #671

wants to merge 1 commit into from

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Sep 2, 2024

I believe these are completely unused. They were still being created/updated though.

@Swatinem Swatinem requested a review from a team September 2, 2024 11:54
@Swatinem Swatinem self-assigned this Sep 2, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         435      434       -1     
  Lines       36925    36581     -344     
==========================================
- Hits        36165    35827     -338     
+ Misses        760      754       -6     
Flag Coverage Δ
integration 97.93% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 97.93% <100.00%> (-0.01%) ⬇️
unit 97.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.63% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.04% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/tests/factories/core.py 99.34% <ø> (-0.05%) ⬇️
services/report/__init__.py 96.21% <100.00%> (-0.10%) ⬇️
services/tests/test_report.py 100.00% <ø> (ø)

... and 37 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (66ca059) to head (d0fb6ee).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         435      434       -1     
  Lines       36925    36581     -344     
==========================================
- Hits        36165    35827     -338     
+ Misses        760      754       -6     
Flag Coverage Δ
integration 97.93% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 97.93% <100.00%> (-0.01%) ⬇️
unit 97.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.63% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.04% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/tests/factories/core.py 99.34% <ø> (-0.05%) ⬇️
services/report/__init__.py 96.21% <100.00%> (-0.10%) ⬇️
services/tests/test_report.py 100.00% <ø> (ø)

... and 37 files with indirect coverage changes

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (66ca059) to head (d0fb6ee).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         476      474       -2     
  Lines       38251    37907     -344     
==========================================
- Hits        37483    37145     -338     
+ Misses        768      762       -6     
Flag Coverage Δ
integration 97.93% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 97.93% <100.00%> (-0.01%) ⬇️
unit 97.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.75% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.04% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/tests/factories/core.py 100.00% <ø> (ø)
services/report/__init__.py Critical 96.22% <100.00%> (-0.10%) ⬇️
services/tests/test_report.py 100.00% <ø> (ø)

... and 38 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.Upload
run/app.tasks.upload.UploadProcessor
run/app.tasks.upload.PreProcessUpload

Copy link

codecov-public-qa bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (66ca059) to head (d0fb6ee).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         435      434       -1     
  Lines       36925    36581     -344     
==========================================
- Hits        36165    35827     -338     
+ Misses        760      754       -6     
Flag Coverage Δ
integration 97.93% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 97.93% <100.00%> (-0.01%) ⬇️
unit 97.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.63% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.04% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/tests/factories/core.py 99.34% <ø> (-0.05%) ⬇️
services/report/__init__.py 96.21% <100.00%> (-0.10%) ⬇️
services/tests/test_report.py 100.00% <ø> (ø)

... and 37 files with indirect coverage changes

I believe these are completely unused. They were still being created/updated though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant