-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create upload test tasks #95
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 89.35% 89.41% +0.05%
==========================================
Files 115 115
Lines 9321 9383 +62
Branches 1473 1486 +13
==========================================
+ Hits 8329 8390 +61
Misses 789 789
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 91.39% 91.43% +0.04%
==========================================
Files 122 122
Lines 9342 9404 +62
Branches 1587 1627 +40
==========================================
+ Hits 8538 8599 +61
Misses 789 789
- Partials 15 16 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 89.35% 89.41% +0.05%
==========================================
Files 115 115
Lines 9321 9383 +62
Branches 1473 1486 +13
==========================================
+ Hits 8329 8390 +61
Misses 789 789
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think calling it just "test" will cause confusion because it's too generic of a name. To make sure it's clear that this is part of test result processing product I think you should always refer to it as "test result" or "test outcome".
Signed-off-by: joseph-sentry <[email protected]>
8b17e1a
to
ce9fda9
Compare
shared/utils/enums.py
Outdated
@@ -43,4 +43,5 @@ class TaskConfigGroup(Enum): | |||
synchronize = "synchronize" | |||
timeseries = "timeseries" | |||
upload = "upload" | |||
upload_test_result = "upload_test_result" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just test_results
? All the test result ingestion tasks can be in that same group. I'm using app.tasks.bundle_analysis.<TaskName>
for bundle analysis stuff.
Depends on: #91