Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create upload test tasks #95

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Create upload test tasks #95

merged 8 commits into from
Dec 15, 2023

Conversation

joseph-sentry
Copy link
Contributor

Depends on: #91

@codecov-qa
Copy link

codecov-qa bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8e129f) 89.35% compared to head (316d928) 89.41%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   89.35%   89.41%   +0.05%     
==========================================
  Files         115      115              
  Lines        9321     9383      +62     
  Branches     1473     1486      +13     
==========================================
+ Hits         8329     8390      +61     
  Misses        789      789              
- Partials      203      204       +1     
Flag Coverage Δ
python3.10 88.61% <100.00%> (+0.08%) ⬆️
python3.11 88.61% <100.00%> (+0.08%) ⬆️
python3.12 88.61% <100.00%> (+0.08%) ⬆️
python3.8 88.70% <100.00%> (+0.08%) ⬆️
python3.9 88.96% <100.00%> (+0.08%) ⬆️
rust 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8e129f) 91.39% compared to head (316d928) 91.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   91.39%   91.43%   +0.04%     
==========================================
  Files         122      122              
  Lines        9342     9404      +62     
  Branches     1587     1627      +40     
==========================================
+ Hits         8538     8599      +61     
  Misses        789      789              
- Partials       15       16       +1     
Flag Coverage Δ
python3.10 88.61% <100.00%> (+0.08%) ⬆️
python3.11 88.61% <100.00%> (+0.08%) ⬆️
python3.12 88.61% <100.00%> (+0.08%) ⬆️
python3.8 88.70% <100.00%> (+0.08%) ⬆️
python3.9 88.96% <100.00%> (+0.08%) ⬆️
rust 90.05% <ø> (ø)
smart-labels 91.62% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Dec 8, 2023

Codecov Report

Merging #95 (316d928) into main (e8e129f) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   89.35%   89.41%   +0.05%     
==========================================
  Files         115      115              
  Lines        9321     9383      +62     
  Branches     1473     1486      +13     
==========================================
+ Hits         8329     8390      +61     
  Misses        789      789              
- Partials      203      204       +1     
Flag Coverage Δ
python3.10 88.61% <100.00%> (+0.08%) ⬆️
python3.11 88.61% <100.00%> (+0.08%) ⬆️
python3.12 88.61% <100.00%> (+0.08%) ⬆️
python3.8 88.70% <100.00%> (+0.08%) ⬆️
python3.9 88.96% <100.00%> (+0.08%) ⬆️
rust 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/celery_config.py 100.00% <100.00%> (ø)
shared/utils/enums.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think calling it just "test" will cause confusion because it's too generic of a name. To make sure it's clear that this is part of test result processing product I think you should always refer to it as "test result" or "test outcome".

@@ -43,4 +43,5 @@ class TaskConfigGroup(Enum):
synchronize = "synchronize"
timeseries = "timeseries"
upload = "upload"
upload_test_result = "upload_test_result"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just test_results? All the test result ingestion tasks can be in that same group. I'm using app.tasks.bundle_analysis.<TaskName> for bundle analysis stuff.

@joseph-sentry joseph-sentry merged commit e008e9f into main Dec 15, 2023
23 checks passed
@joseph-sentry joseph-sentry deleted the joseph/upload-test-tasks branch December 15, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants