Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add Python 3.12 #92

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

FraBle
Copy link
Contributor

@FraBle FraBle commented Dec 1, 2023

Addresses codecov/engineering-team#874

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@FraBle
Copy link
Contributor Author

FraBle commented Dec 5, 2023

Looks like this is blocked until pony adopts Python 3.12 support: ponyorm/pony#694
Related discussion in mutmut: boxed/mutmut#295 (comment)

@trent-codecov
Copy link
Contributor

trent-codecov commented Dec 6, 2023

Thanks for the great work here @FraBle!

@giovanni-guidini / @scott-codecov can you evaluate our usage of mutmut here and see if its worth blocking this PR. I'm not sure what value we are getting out of it. As far as I know we aren't using pony in our app and that project doesn't look particularly active.

@trent-codecov
Copy link
Contributor

@FraBle can you just leave mutations on 3.11. We can upgrade that to 3.12 once the underlying library supports it. That should let us get this over the finish line.

@FraBle
Copy link
Contributor Author

FraBle commented Dec 12, 2023

@trent-codecov Do we expect ATS to work fine with Python 3.12? I set it to 3.12 here, but it gets skipped for forks.

@giovanni-guidini
Copy link
Contributor

@trent-codecov Do we expect ATS to work fine with Python 3.12? I set it to 3.12 here, but it gets skipped for forks.

Hopefully, yes. Under the hood it uses the installed pytest version. As long as we can run tests, it should work. But changing ATS is much easier, since it's our tool :P.

@trent-codecov trent-codecov merged commit 6fd5d86 into codecov:main Dec 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants