Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over some django_apps and their associated models to shared #469

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Jan 9, 2025

This just straight-up copies the following directories from codecov-api:

compare, labelanalysis, profiling and staticanalysis

I would like to have access to these models from the worker, so thats why I am moving those to shared.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (99581a7) to head (36a8ade).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   90.55%   89.97%   -0.58%     
==========================================
  Files         404      324      -80     
  Lines       12562     9197    -3365     
  Branches     2107     1633     -474     
==========================================
- Hits        11375     8275    -3100     
+ Misses       1078      859     -219     
+ Partials      109       63      -46     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem force-pushed the swatinem/migrate-models branch from c1c9cb2 to 36a8ade Compare January 10, 2025 14:17
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall lgtm! When reimporting, can we try letting it sit in staging for a day or something just to make sure they're working fine?

@Swatinem Swatinem added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit de4b37b Jan 14, 2025
7 of 8 checks passed
@Swatinem Swatinem deleted the swatinem/migrate-models branch January 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants