-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle Analysis: add ability to ingest dynamic imports #445
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
shared/bundle_analysis/migrations/v004_add_dynamic_imports.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
from sqlalchemy import text | ||
from sqlalchemy.orm import Session | ||
|
||
|
||
def add_dynamic_imports(db_session: Session): | ||
""" | ||
Adds a table called dynamic_imports (DynamicImport model name) | ||
This table represents for a given Chunk what are its dynamically | ||
imported Assets, if applicable. | ||
|
||
There is no data available to migrate, any older versions of bundle | ||
reports will be considered to not have dynamic imports | ||
""" | ||
stmts = [ | ||
""" | ||
CREATE TABLE dynamic_imports ( | ||
chunk_id integer not null, | ||
asset_id integer not null, | ||
primary key (chunk_id, asset_id), | ||
foreign key (chunk_id) references chunks (id), | ||
foreign key (asset_id) references assets (id) | ||
); | ||
""", | ||
] | ||
|
||
for stmt in stmts: | ||
db_session.execute(text(stmt)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
from shared.bundle_analysis.parsers.base import ParserInterface | ||
from shared.bundle_analysis.parsers.v1 import ParserV1 | ||
from shared.bundle_analysis.parsers.v2 import ParserV2 | ||
from shared.bundle_analysis.parsers.v3 import ParserV3 | ||
|
||
__all__ = [ | ||
"ParserInterface", | ||
"ParserV1", | ||
"ParserV2", | ||
"ParserV3", | ||
] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need any indexes on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The good thing about these "databases" are that it is super small (like 100kB), it only matches bundle data for 1 singular commit. This means we don't need to worry about performance on querying things haha.