Add a proper index to Upload (aka ReportSession)
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-codecov
approved these changes
Dec 3, 2024
This adds an index covering `report_id` and `upload_type`, in that order. The most frequent queries use `report_id`, and some further index by `upload_type`. So this newly added index will cover those two frequent queries. Indexing additionally on `order_number` is not necessary. While we do run queries using all three fields, those are not as frequent, and they should be served by the newly added index as well. One more argument against indexing on the `order_number` is that we `UPDATE` this field when processing an upload, which means we would have to touch and update the index on such operation as well, which we could also avoid.
Swatinem
force-pushed
the
swatinem/upload-idx-part1
branch
from
04713aa to
3af2101
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 90.54% 89.97% -0.58%
==========================================
Files 403 324 -79
Lines 12538 9199 -3339
Branches 2105 1633 -472
==========================================
- Hits 11353 8277 -3076
+ Misses 1076 859 -217
+ Partials 109 63 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an index covering
report_idandupload_type, in that order. The most frequent queries usereport_id, and some further index byupload_type.So this newly added index will cover those two frequent queries. Indexing additionally on
order_numberis not necessary. While we do run queries using all three fields, those are not as frequent, and they should be served by the newly added index as well. One more argument against indexing on theorder_numberis that weUPDATEthis field when processing an upload, which means we would have to touch and update the index on such operation as well, which we could also avoid.