Bundle Analysis: Make a lib to fetch route by a file name #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
commented
Nov 26, 2024
| @@ -18,7 +18,7 @@ | |||
| def attempt_json_dumps(value: Any) -> str: | |||
| def assert_string_keys(d: dict[Any, Any]) -> None: | |||
| for k, v in d.items(): | |||
| if type(k) is not str: | |||
| if not isinstance(k, str): | |||
There was a problem hiding this comment.
ruff made this chage.
adrian-codecov
approved these changes
Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
- Coverage 90.56% 89.81% -0.75%
==========================================
Files 390 324 -66
Lines 11768 9379 -2389
Branches 1974 1677 -297
==========================================
- Hits 10658 8424 -2234
+ Misses 1026 891 -135
+ Partials 84 64 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For codecov/engineering-team#2570
Given a file path/name of a module we want to compute what route of the application this file belongs to. This class aims to make that transformation by applying custom file based routing rules for various supported plugins. Supported plugins are:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.