[vuln] Bump urllib3 #265
Merged
[vuln] Bump urllib3 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 90.15% 89.44% -0.71%
==========================================
Files 341 324 -17
Lines 10798 10186 -612
Branches 1930 1841 -89
==========================================
- Hits 9735 9111 -624
- Misses 1001 1005 +4
- Partials 62 70 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohitvinnakota-codecov
force-pushed
the
rvinnakota-vuln-urllib3
branch
from
563e077 to
0930ee0
Compare
giovanni-guidini
approved these changes
Jul 3, 2024
| @@ -42,7 +42,7 @@ | |||
| "typing_extensions", | |||
| "google-auth>=2.21.0", | |||
| "google-cloud-pubsub>=2.13.6", | |||
| "urllib3>=1.25.4,<1.27", | |||
There was a problem hiding this comment.
DO you know why the requirement was <1.27? Just curious
There was a problem hiding this comment.
I vaguely remember seeing a vuln where v 1.27 - v2.2 were affected, but I can't find it now
I set it ==1.26.19 just to be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch urllib3
This closes https://github.com/codecov/internal-issues/issues/551
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.