feat: extend configuration for comment.required_changes
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 90.06% 89.48% -0.58%
==========================================
Files 339 324 -15
Lines 10696 10222 -474
Branches 1924 1851 -73
==========================================
- Hits 9633 9147 -486
- Misses 1004 1005 +1
- Partials 59 70 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
approved these changes
Jun 25, 2024
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jun 25, 2024
As you can see, this is a big change. It implements the changes from codecov/shared#259 into the worker. It does make the require changes condition way more complex. I also took the time to audit the unit tests, but I think they are valid now. Perhaps I should add more integration tests just in case...
|
I'll hold off merging this until codecov/worker#520 is approved. |
We are extending the configuration for required_changes. ticket: codecov/engineering-team#1966 I might have overengineered the different conditions, but being able to combine in both AND and OR operations is somewhat tricky. In the end it's a satisfaction problem in that all the elements in the conditions list need to be satisfied for the comment to occur, and the elements themselves express and OR grouping.
Use a proper parsing lib instead of ad-hoc code to parse the required_changes string options. Interface remains unchanged.
giovanni-guidini
force-pushed
the
gio/negative-changes
branch
from
2aed815 to
0704331
Compare
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jun 26, 2024
As you can see, this is a big change. It implements the changes from codecov/shared#259 into the worker. It does make the require changes condition way more complex. I also took the time to audit the unit tests, but I think they are valid now. Perhaps I should add more integration tests just in case...
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are extending the configuration for required_changes.
ticket: codecov/engineering-team#1966
I might have overengineered the different conditions, but being able to combine in both AND and OR
operations is somewhat tricky. In the end it's a satisfaction problem in that all the elements in the
conditions list need to be satisfied for the comment to occur, and the elements themselves express
and OR grouping.